Skip to content

Conversation

@camrynl
Copy link
Contributor

@camrynl camrynl commented Apr 3, 2025

Reason for Change:
skipping flakey test for k8s e2e kubectl portforward

Issue Fixed:

Requirements:

Notes:
will be fixed in k8s 1.33

Copilot AI review requested due to automatic review settings April 3, 2025 22:35
@camrynl camrynl requested a review from a team as a code owner April 3, 2025 22:35
@camrynl camrynl requested a review from danlai-ms April 3, 2025 22:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

.pipelines/cni/k8s-e2e/k8s-e2e.jobs.yaml:97

  • The new inline conditional mapping syntax using '?' and ':' should be verified with your YAML parser or templating engine to ensure it is supported in your environment.
- ? ${{ if and( eq(parameters.service, true), contains(parameters.cni, 'cni') ) }}

.pipelines/cni/k8s-e2e/k8s-e2e-job-template.yaml:82

  • Ensure that the inline conditional mapping syntax with '?' and ':' is compatible with your YAML processor in this template update as well.
- ? ${{ if and( eq(parameters.service, true), contains(parameters.cni, 'cni') ) }}

jpayne3506
jpayne3506 previously approved these changes Apr 4, 2025
@camrynl camrynl added this pull request to the merge queue Apr 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 7, 2025
@camrynl camrynl enabled auto-merge April 7, 2025 20:45
@camrynl camrynl added this pull request to the merge queue Apr 7, 2025
Merged via the queue into master with commit e722954 Apr 7, 2025
92 checks passed
@camrynl camrynl deleted the camrynl/skipk8sportforward branch April 7, 2025 22:57
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
* ci: skip new test for k8s 1.32 kubectl portforward shutdown

* remove formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants